Skip to content

Run scala2-compat scripted tests during test_bootstrapped in CI #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Oct 13, 2020

This PR adds the Scala 2 compatibility/interop tests to the test_bootstrapped job in CI. The status quo is that these tests are only run during the nightly scheduled CI (as part of test_sbt).

Adding the tests to the test_bootstrapped job means any regressions are noticed sooner, and CI configuration overrides should not be needed when fixing Scala 2 interop issues such as #9916.

The tests are currently implemented as sbt scripted tests, which have a high per-test startup overhead, but the number of tests is small so the overall impact on CI runtime should be minimal (1-2 minutes).

An alternative to #9990.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, congrats on getting PR #10000 🥳!

The tests are currently implemented as sbt scripted tests, which have a high per-test startup overhead, but the number of tests is small so the overall impact on CI runtime should be minimal (1-2 minutes).

It's fine for now, but if we end up adding more tests we should either merge them together in one sbt project or finally make our testing framework capable of calling scalac for specific files and use that instead.

@griggt
Copy link
Contributor Author

griggt commented Oct 14, 2020

if we end up adding more tests we should either merge them together in one sbt project or finally make our testing framework capable of calling scalac for specific files and use that instead.

Agreed. I hope to find some time soon to do some work on the latter.

@smarter smarter merged commit ca67e4d into scala:master Oct 14, 2020
@griggt griggt deleted the scala2-compat-ci branch October 22, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants