Skip to content

_ should be a valid completion in imports #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smarter opened this issue Nov 18, 2018 · 0 comments
Closed

_ should be a valid completion in imports #5460

smarter opened this issue Nov 18, 2018 · 0 comments

Comments

@smarter
Copy link
Member

smarter commented Nov 18, 2018

If I type:

import scala._

Then the completion suggested is _root_, and with vscode default settings, this completion will be selected when pressing Enter. We can avoid this issue by adding _ to the list of completions we return (and we should also figure out why _root_ appears in there because that doesn't make sense).

Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 20, 2018
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 20, 2018
Duhemm added a commit to dotty-staging/dotty that referenced this issue Nov 21, 2018
@Duhemm Duhemm closed this as completed in 43455e4 Nov 23, 2018
Duhemm added a commit that referenced this issue Nov 23, 2018
Fix #5460: Improve completion of import nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant