Skip to content

Symbol encoding should be done late #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odersky opened this issue Feb 28, 2014 · 6 comments
Closed

Symbol encoding should be done late #30

odersky opened this issue Feb 28, 2014 · 6 comments

Comments

@odersky
Copy link
Contributor

odersky commented Feb 28, 2014

Right now, + is encoded to $plus in phase Namer. We agreed it should be done during bytecode generation instead.
@sjrd sjrd self-assigned this Feb 28, 2014
@xeno-by
Copy link

xeno-by commented Feb 28, 2014

Would then ClassfileReader have to undo name mangling?

@sjrd
Copy link
Member

sjrd commented Feb 28, 2014

Yes, it would.

@xeno-by
Copy link

xeno-by commented Feb 28, 2014

Great news!

@smarter
Copy link
Member

smarter commented Nov 18, 2015

Is it time to revisit this yet?

@smarter smarter mentioned this issue Nov 18, 2015
Closed
@smarter
Copy link
Member

smarter commented Nov 21, 2015

See also https://issues.scala-lang.org/browse/SI-2034 which affects Dotty as well.

OlivierBlanvillain pushed a commit to OlivierBlanvillain/dotty that referenced this issue Dec 12, 2016
@dragos @OlivierBlanvillain
Fixed looping data flow analyzer (due to asymme...
920078d 
Fixed looping data flow analyzer (due to asymmetric equals method in
lattices) (ticket scala#30).
@nicolasstucki
Copy link
Contributor

This issue was solved with #2128.

@sjrd sjrd removed their assignment Oct 4, 2018
noti0na1 added a commit to noti0na1/dotty that referenced this issue Oct 17, 2019
@noti0na1
Merge pull request scala#30 from noti0na1/dotty-explicit-nulls-small
fa43361 
* revert changes to `typedThrow`; the expression of `throw` cannot be `null`
* move `flowFacts` in `Context`
* modify comment in `Flags` about `JavaEnumValue`
* remove extra function in `simpleApply`
* remove extra comments
@chrislailee chrislailee mentioned this issue Jun 18, 2021
Closed
pikinier20 added a commit that referenced this issue Aug 16, 2022
@pikinier20
Merge pull request #30 from pikinier20/scaladoc/concise-view
4e9f2de 
Scaladoc/concise view
szymon-rd pushed a commit that referenced this issue Dec 9, 2022
@kamilszewczyk0
Merge pull request #30 from szymon-rd/style-fixes
532e42c 
styles corections according to designer specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@smarter @sjrd @xeno-by @odersky @nicolasstucki