Skip to content

Reflection defines two extensions named memberType with different meaning #12299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Apr 30, 2021 · 0 comments · Fixed by #12322
Closed

Reflection defines two extensions named memberType with different meaning #12299

smarter opened this issue Apr 30, 2021 · 0 comments · Fixed by #12322
Assignees
@nicolasstucki
Labels
itype:enhancement
Milestone
3.0.1

Comments

@smarter
Copy link
Member

smarter commented Apr 30, 2021 •
edited
Loading

It's very confusing that:

  • tp.memberType(sym) gives you back the type of the member sym as seen from tp
  • but sym.memberType(name) gives you back the symbol of a type member named name

IMO, we should rename the method on symbol to typeMember instead (same with a bunch of other methods on member like memberField, etc).
@smarter smarter added this to the 3.1.0 milestone Apr 30, 2021
odersky added a commit to dotty-staging/dotty that referenced this issue May 3, 2021
@odersky
Export constructor proxies
56c40f8 
When creating an exported type alias of a class that has a constructor proxy companion,
export an alias for that companion with it. The alias is again a constructor proxy.

Fixes scala#12299
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 4, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
2659c9c 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Changes
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
@nicolasstucki nicolasstucki mentioned this issue May 4, 2021
Merged
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 4, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
322529f 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Changes
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 11, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
6e92755 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Changes
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 11, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
f631dce 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Changes
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 11, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
d2f4a01 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Changes
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 12, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
4510441 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Add replacements
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
nicolasstucki added a commit to dotty-staging/dotty that referenced this issue May 17, 2021
@nicolasstucki
Rename reflect.Type { memberXyz => xyzMember }
bc34a66 
Avoid ambigouity between `Type.memberType` and `Symbol.memberType`

Add replacements
* `memberField` -> `fieldMember`
* `memberFields` -> `fieldMembers`
* `memberMethod` -> `methodMember`
* `memberMethods` -> `methodMembers`
* `memberType` -> `typeMember`
* `memberTypes` -> `typeMembers`

Closes scala#12299
@Kordyjan Kordyjan modified the milestones: 3.1.0, 3.0.1 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
itype:enhancement
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

Rename reflect.Type { memberXyz => xyzMember } dotty-staging/dotty
3 participants
@smarter @nicolasstucki @Kordyjan