Skip to content

Setup mima to check for backwards- and forward- incompatible change #11939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smarter opened this issue Mar 29, 2021 · 2 comments
Closed

Setup mima to check for backwards- and forward- incompatible change #11939

smarter opened this issue Mar 29, 2021 · 2 comments
Assignees
@sjrd
Labels
area:infrastructure itype:bug
Milestone
3.0.1-RC1

Comments

@smarter
Copy link
Member

smarter commented Mar 29, 2021 •
edited
Loading

We need to add https://github.com/lightbend/mima/ to our build and run its checks as part of our CI, disallowing both backward-incompatible and forward-incompatible change (that is, mimaCheckDirection needs to be set to both), eventually we'll also need to tweak it to allow forward-incompatible changes after a minor version bump.
@smarter smarter added this to the 3.0.0 milestone Mar 29, 2021
@smarter
Copy link
Member Author

smarter commented Mar 29, 2021 •
edited
Loading

To be clear, mima should only be enabled in scala3-library, scala3-library-js, scala3-interfaces and tasty-core, for everything else we make no guarantee (and I guess we could also document this clearly by setting versionScheme := Some("semver-spec") in these projects if I'm not mistaken /cc @sjrd)

@anatoliykmetyuk anatoliykmetyuk modified the milestones: 3.0.0-RC3, 3.0.x Apr 19, 2021
@sjrd
Copy link
Member

sjrd commented Apr 28, 2021

Well, after more time than I wish to admit, I have finally discovered that MiMa simply does not support Scala 3 artifacts at the moment. :( The fix is in main, but not released.

I have requested a release at lightbend-labs/mima#619

sjrd added a commit to dotty-staging/dotty that referenced this issue May 7, 2021
@sjrd
Fix scala#11939: Set up MiMa for scala3-interfaces in scala3-library.
640c9a8 
This already detects a couple things that break the backward source
compatibility guarantee. They are excluded in
`project/MiMaFilters.scala`. They should be reverted before we
publish 3.0.1, or we should jump straight to 3.1.0.
sjrd added a commit to dotty-staging/dotty that referenced this issue May 11, 2021
@sjrd
Fix scala#11939: Set up MiMa for scala3-interfaces in scala3-library.
61d0d6c
@anatoliykmetyuk anatoliykmetyuk modified the milestones: 3.0.x, 3.0.1-RC1 May 12, 2021
smarter added a commit that referenced this issue May 15, 2021
@smarter
Merge pull request #12371 from dotty-staging/setup-mima
83e17f1 
Fix #11939: Set up MiMa for scala3-interfaces in scala3-library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjrd sjrd

Labels
area:infrastructure itype:bug
Projects
None yet
Milestone
3.0.1-RC1
Development

No branches or pull requests
3 participants
@smarter @sjrd @anatoliykmetyuk