Skip to content

Scala Native Support #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2022
Merged

Scala Native Support #188

merged 3 commits into from
Oct 25, 2022

Conversation

j-mie6
Copy link
Contributor

@j-mie6 j-mie6 commented Oct 24, 2022

Added Scala native support fixing #187, but this required, for some reason, removing the -scala-output-version:3.0 flag for Scala 3 compilation. With that flag on, there are two errors;

[error] The class scala.scalanative.unsafe.package cannot be loaded from file scala/scalanative/unsafe/package.tasty because its TASTy format is not compatible with the one of the targeted Scala release (3.0):
[error] highest allowed: 28.0-0
[error] found:           28.1-0
[error]               
[error] The class scala.scalanative.unsafe.UnsafePackageCompat cannot be loaded from file scala/scalanative/unsafe/UnsafePackageCompat.tasty because its TASTy format is not compatible with the one of the targeted Scala release (3.0):
[error] highest allowed: 28.0-0
[error] found:           28.1-0
[error]               
[error] two errors found

@SethTisue
Copy link
Member

-scala-output-version has been withdrawn, as per https://scala-lang.org/blog/2022/08/17/long-term-compatibility-plans.html, so no worries there, you can take it out entirely

SethTisue
SethTisue reviewed Oct 25, 2022
View reviewed changes
build.sbt Outdated
@@ -42,6 +42,11 @@ lazy val collectionContrib = crossProject(JVMPlatform, JSPlatform)
// Scala.js cannot run forked tests
Test / fork := false
)
.nativeEnablePlugins(ScalaNativeJUnitPlugin)
.nativeSettings(
Test / fork := false // is this needed?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI could tell us, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll allow for forks and see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now we know :)

@SethTisue SethTisue merged commit 1310a3c into scala:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mie6 @SethTisue