Fix conditional error in benv script #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Feb 2, 2018
| @@ -139,12 +139,12 @@ function setFrequency() { | |||
|
|
|||
| local freqs=$(cat /proc/cpuinfo | grep MHz) | |||
| local c=$(echo "$freqs" | grep $cpuFrequency.000 | wc -l) | |||
| [[ "$c" == "4" ]] || | |||
| [[ "$c" != "4" ]] || | |||
There was a problem hiding this comment.
I think it was correct before; if c is 4, we seen all 4 cpus at the correct frequency, so || will not execute err. Or am I missing something?
There was a problem hiding this comment.
You're right Lukas, there was another error in the code (that I modified) that automatically made me think this was the line causing me problems. I didn't even think about what I was modifying, I was in trial and error mode 😄. In my case, this condition is almost always false because I use intel_pstate and it reports results that vary by small digits of Hz, I guess you don't see that because you use acpi_cpufreq.
There was a problem hiding this comment.
yes, we disabled intel_pstate. see some notes here: scala/scala-dev#338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.