Skip to content

Add cbuild.sh, a configurable Community Build wrapper for dbuild #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Mar 16, 2017
Merged

Add cbuild.sh, a configurable Community Build wrapper for dbuild #478

merged 1 commit into from Mar 16, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2017

tested against https://github.com/typelevel/catalysts-docker/tree/master/artifactory-oss by running:

./cbuild.sh -v 2.12 -r resolvers/resolvers-catalysts-docker.conf 

@ghost
Copy link
Author

ghost commented Feb 12, 2017

Note that the original structure (with the three config files in the root directory) can be maintained by simply running:

./cbuild.sh -c .

@SethTisue
Copy link
Member

hey, sorry I haven't had time to try this quite yet, but I expect to get to it soon. don't worry about the merge conflict, I can sort out that later.

@ghost
Copy link
Author

ghost commented Feb 15, 2017

@SethTisue np, and thanks for update 😄

btw, I know the PR as -is is somewhat intrusive, I had some thoughts at some stage to make it less so, but then it was less clear as to the final goal - tldr, happy to discuss on gitter/here first.

@SethTisue
Copy link
Member

SethTisue commented Feb 23, 2017

still planning to return to this before too much longer :-\

@SethTisue
Copy link
Member

SethTisue commented Mar 15, 2017

I merged this with origin/2.12.x and pushed the result to https://github.com/SethTisue/community-builds/tree/BennyHill-fix/474

it seems to be working for me locally. if we find it works on Jenkins too, I'm inclined to just merge it and try it for a while.

I've queued up a Jenkins run here: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1335/consoleFull but it's 404 til the queue clears, probably tomorrow.

@SethTisue
Copy link
Member

sigh, Jenkins ran out of disk. I've queued up a new run here: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1339/consoleFull but it's 404 til the queue clears

@SethTisue
Copy link
Member

the one failure in the test run is unrelated, so I'm going to go ahead and merge this. thank you Alistair — for the nice PR, and for all your patience.

@SethTisue SethTisue merged commit 7d782f6 into scala:2.12.x Mar 16, 2017
@SethTisue
Copy link
Member

I know the PR as -is is somewhat intrusive, I had some thoughts at some stage to make it less so, but then it was less clear as to the final goal - tldr, happy to discuss on gitter/here first

I backed out a couple aspects of the naming and structure that I found a bit "intrusive" — see f073143 and d50b71b. but this is provisional and open to further discussion and further changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants