This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Dotty #4013 #517
Closed
Dotty #4013 #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of Dotty fixes several unsoundness issues and remove the unsound protected[this] escape hatch for variance checking. See scala/scala3#4013
allanrenucci
force-pushed
the
dotty-#4013
branch
from
ae7d7e5 to
0d638e7
Compare
szeiger
reviewed
Mar 20, 2018
| object ImmutableArray extends StrictOptimizedClassTagSeqFactory[ImmutableArray] { self => | ||
| val untagged: SeqFactory[ImmutableArray] = new ClassTagSeqFactory.AnySeqDelegate(self) | ||
| object ImmutableArray extends StrictOptimizedClassTagSeqFactory[ImmutableArray] { | ||
| val untagged: SeqFactory[ImmutableArray] = new ClassTagSeqFactory.AnySeqDelegate(this) |
There was a problem hiding this comment.
What's the reason for these changes? Just removing some unnecessary code, or is there a change in Dotty that necessitates this?
There was a problem hiding this comment.
We recently disallowed named self in scala/scala3#4118. We might reconsider it though
There was a problem hiding this comment.
But the fix refers to the wrong this! Btw we will revert #4118.
|
Superseded by #519. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of Dotty fixes several unsoundness issues and remove the unsound protected[this] escape hatch for variance checking. See scala/scala3#4013
@julienrf You might want to play with this branch and make it compile with Dotty