Fix hang in nested fixpoint iteration #871
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #871 will degrade performances by 5.34%Comparing Summary
Benchmarks breakdown
|
MichaReiser
force-pushed
the
fix-hang
branch
2 times, most recently
from
4140252 to
a6d9b6c
Compare
MichaReiser
commented
May 21, 2025
| tracing::debug!( | ||
| "Waiting for {head_index:?} results in a cycle, return {database_key_index:?} once all other cycle heads completed to allow the outer cycle to make progress." | ||
| ); | ||
| hit_cycle = true; |
There was a problem hiding this comment.
I changed this to early-return in #861 but I think that was incorrect. Not early-returning fixes the ty panic for kopf. I might spend some more time to come up with a test case for it but I might also just leave it at it (I already spent an entire week on this :s)
|
This does not fix all occurences of the cycle iteration panic, I can still reproduce it on pandas-stubs |
carljm
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a hang in multithreaded fixpoint iteration where the
Memo::provisional_retryretried over and over again because all its cycle heads other than itself were finalized at this point.This also fixes the panic from the
kopfrepro listed in #831