Skip to content

Updates Jest to 20.0.4. #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2017
Merged

Updates Jest to 20.0.4. #1011

merged 3 commits into from
Jun 29, 2017

Conversation

futuremint
Copy link
Contributor

Also updates jest snapshots.

Also updates jest snapshots.
@futuremint futuremint requested a review from donnieberg June 26, 2017 20:04
@tweettypography tweettypography temporarily deployed to design-system-react-co-pr-1011 June 26, 2017 20:04 Inactive
@interactivellama
Copy link
Contributor

Getting this in heroku:

-----> Node.js app detected
-----> Creating runtime environment
       
       NPM_CONFIG_LOGLEVEL=error
       NPM_CONFIG_PRODUCTION=false
       NODE_VERBOSE=false
       NODE_ENV=production
       NODE_MODULES_CACHE=true
-----> Installing binaries
       engines.node (package.json):  >=4.4.0
       engines.npm (package.json):   ^3.9.0
       
       Resolving node version >=4.4.0 via semver.io...
       Downloading and installing node 8.1.2...
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
-----> Build failed
       
       We're sorry this build is failing! You can troubleshoot common issues here:
       https://devcenter.heroku.com/articles/troubleshooting-node-deploys
       
       Some possible problems:
       
       - Dangerous semver range (>) in engines.node
       https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version
       
       Love,
       Heroku
       
 !     Push rejected, failed to compile Node.js app.
 !     Push failed

https://dashboard.heroku.com/pipelines/22a311ed-7832-4b2d-8997-3e9242544b73
Previous PR seemed fine.

@futuremint
Copy link
Contributor Author

Weird, I definitely didn't touch that part of package.json here. I'll investigate more if I have time tomorrow.

@tweettypography tweettypography temporarily deployed to design-system-react-co-pr-1011 June 27, 2017 12:38 Inactive
@interactivellama
Copy link
Contributor

Maybe they just happened to update Travis to Node 8.x by default.

@futuremint
Copy link
Contributor Author

Yes, if you look in the error log it was running Node 8.1.2... not sure we're ready for that so I'm keeping it at 6.x for now.

@futuremint futuremint requested review from interactivellama and removed request for donnieberg June 27, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants