Skip to content

Retrieve more information of fundamental groups of plane curves #36768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 148 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
148 commits
Select commit Hold shift + click to select a range
c7d36ca
new branch
enriqueartal Jul 20, 2023
26c64cc
Initial changes to deal with ordered hyperplane arrangements
enriqueartal Jul 21, 2023
0be51f8
Merge branch 'puiseux' into arrangements
enriqueartal Jul 21, 2023
9b83308
Merge branch 'puiseux' into arrangements
enriqueartal Jul 21, 2023
0d08854
creating element for ordered hyperplane arrangements to have fundamen…
enriqueartal Jul 22, 2023
6781a4b
correcting examples
enriqueartal Jul 22, 2023
ae49054
typo
enriqueartal Jul 24, 2023
0c0a320
merge
enriqueartal Jul 31, 2023
464a494
merge again
enriqueartal Jul 31, 2023
298c79b
Merge branch 'puiseux' into arrangements
enriqueartal Jul 31, 2023
4e53120
Merge branch 'puiseux' into arrangements
enriqueartal Aug 2, 2023
64f2bd8
Merge branch 'sagemath:develop' into arrangements
enriqueartal Aug 7, 2023
93fa393
merge examples arrangement.py
enriqueartal Aug 13, 2023
5bcb806
Merge branch 'puiseux' into arrangements
enriqueartal Aug 15, 2023
77dd950
Merge branch 'puiseux' into arrangements
enriqueartal Aug 22, 2023
99653de
Merge branch 'puiseux' into arrangements
enriqueartal Aug 23, 2023
f987349
Merge branch 'puiseux' into arrangements
enriqueartal Aug 23, 2023
093ef27
Merge branch 'sagemath:develop' into arrangements
enriqueartal Aug 28, 2023
2d29cb8
Merge branch 'puiseux' into arrangements
enriqueartal Aug 28, 2023
6e7c9f6
Merge branch 'puiseux' into arrangements
enriqueartal Aug 28, 2023
2ce7bfe
getting a line back in doctests for cone
enriqueartal Aug 28, 2023
f275cc9
Merge branch 'puiseux' into arrangements
enriqueartal Aug 29, 2023
22d67c1
try to catch exceptions
enriqueartal Aug 30, 2023
7f91708
check AttributeError
enriqueartal Aug 30, 2023
0d39122
add : after sage in failing doctest
enriqueartal Aug 30, 2023
7b10078
Merge branch 'puiseux' into arrangements
enriqueartal Aug 30, 2023
7aabdf0
merge with puiseux
enriqueartal Aug 30, 2023
2eaf0e5
Merge branch 'puiseux' into arrangements
enriqueartal Sep 1, 2023
9194a23
Merge branch 'sagemath:develop' into arrangements
enriqueartal Sep 2, 2023
0259f36
Merge branch 'arrangements' of github.com:enriqueartal/sage into arra…
enriqueartal Sep 2, 2023
e096e9f
method fundamental group does not work on degree 1
enriqueartal Sep 2, 2023
4dafc7f
add tests and fix trivial cases in projective case
enriqueartal Sep 2, 2023
0df6c84
Merge branch 'sagemath:develop' into arrangements
enriqueartal Sep 11, 2023
05f17b9
Merge branch 'sagemath:develop' into arrangements
enriqueartal Sep 16, 2023
5429f6d
Merge branch 'sagemath:develop' into arrangements
enriqueartal Sep 25, 2023
ee78c10
Merge branch 'sagemath:develop' into arrangements
enriqueartal Sep 28, 2023
51cfe00
first step for vertical
enriqueartal Sep 30, 2023
d289c2c
unwanted character
enriqueartal Sep 30, 2023
c996a59
first vertical tests
enriqueartal Sep 30, 2023
af6853d
add vertical options for fundamental_group_arrangement
enriqueartal Sep 30, 2023
cd323ec
Create the class of affine plane curve arrangements
enriqueartal Oct 1, 2023
a6a2481
errors in zvk, still not class of arrangements of curves
enriqueartal Oct 1, 2023
1715071
new method for arrangements of curves
enriqueartal Oct 1, 2023
a7c2f9b
lint
enriqueartal Oct 2, 2023
fff657b
the class exists
enriqueartal Oct 2, 2023
06b614a
corrections
enriqueartal Oct 2, 2023
e97e7aa
doctesting voronoi_cells
enriqueartal Oct 2, 2023
afc4f22
geometric basis with dictionnary
enriqueartal Oct 2, 2023
bd6df7c
typo
enriqueartal Oct 3, 2023
4e3acdb
correction of braid in segment
enriqueartal Oct 3, 2023
8241fe0
more methods for affine plane curves
enriqueartal Oct 3, 2023
6b69c2f
to do: doctests for fundamental_group_arrangement
enriqueartal Oct 3, 2023
e5a44d0
first pass of doctest in zvk, improving pca
enriqueartal Oct 4, 2023
88577a7
more doctests
enriqueartal Oct 4, 2023
bb0f7c2
arrangements in documentation
enriqueartal Oct 5, 2023
ce641a7
last doctests
enriqueartal Oct 5, 2023
43fcdae
Merge branch 'sagemath:develop' into arrangements
enriqueartal Oct 8, 2023
6bcdec4
forget a commit
enriqueartal Oct 8, 2023
598d832
Merge branch 'sagemath:develop' into arrangements
enriqueartal Oct 15, 2023
b7e6270
improve the class-1
enriqueartal Oct 17, 2023
d602f16
improving class (2)2
enriqueartal Oct 17, 2023
82e54b7
class attributes - 3
enriqueartal Oct 18, 2023
1fb3c76
some more doct-test, vertical lines to be verified
enriqueartal Oct 19, 2023
e7053e4
change documentation of fundamental_group_arrangement
enriqueartal Oct 20, 2023
a540ce8
Merge branch 'sagemath:develop' into arrangements
enriqueartal Oct 21, 2023
8cddcde
Merge branch 'sagemath:develop' into arrangements
enriqueartal Oct 31, 2023
833fac7
Merge branch 'sagemath:develop' into arrangements
enriqueartal Nov 6, 2023
3fdbcea
lint issue
enriqueartal Nov 6, 2023
83c802c
Merge branch 'sagemath:develop' into arrangements
enriqueartal Nov 10, 2023
b87ef6f
sort a list to avoid random failures
enriqueartal Nov 11, 2023
df65666
Merge branch 'sagemath:develop' into arrangements
enriqueartal Nov 12, 2023
7caaf76
some doc typos
enriqueartal Nov 13, 2023
d4682f3
Merge branch 'sagemath:develop' into arrangements
enriqueartal Nov 15, 2023
54f926d
change names in fieldI to avoid strange errors if b is a variable
enriqueartal Nov 18, 2023
e8920d6
Merge branch 'sagemath:develop' into arrangements
enriqueartal Nov 18, 2023
16f3608
comentarios para corregir en plane_curve_arrangement
enriqueartal Nov 22, 2023
98e0809
correcting class of affine arrangements, creating class of projective…
enriqueartal Nov 22, 2023
397224e
working on projective arrangements
enriqueartal Nov 23, 2023
8785db1
method fundamental group for projective curves
enriqueartal Nov 23, 2023
2df222f
doctests and corrections
enriqueartal Nov 23, 2023
11a3fcd
cleaning classes and preparing arrangements
enriqueartal Nov 24, 2023
e6c3757
alpha version for doctests
enriqueartal Nov 24, 2023
e9b2fbb
final changes before PR
enriqueartal Nov 25, 2023
339f220
compute the meridian of the line at infinity in more cases and correc…
enriqueartal Nov 26, 2023
4d1bfea
typo
enriqueartal Nov 26, 2023
345bee5
some more typos
enriqueartal Nov 26, 2023
483aa6c
another typo
enriqueartal Nov 26, 2023
9ffb6e2
yet another typo
enriqueartal Nov 26, 2023
520c365
use sorted_presentation to avoid fake failing tests
enriqueartal Nov 26, 2023
38cf923
make faster the computation in the projective case
enriqueartal Nov 27, 2023
09dde99
Merge branch 'sagemath:develop' into arrangements
enriqueartal Dec 1, 2023
76ad4d4
Merge branch 'sagemath:develop' into arrangements
enriqueartal Dec 6, 2023
3770b4d
small reviewer comments
enriqueartal Dec 6, 2023
be89ec5
unnecessary call to braid_monodromy
enriqueartal Dec 7, 2023
e9e458e
Merge branch 'sagemath:develop' into arrangements
enriqueartal Dec 10, 2023
070db54
Merge branch 'sagemath:develop' into arrangements
enriqueartal Dec 14, 2023
fa2c963
Merge branch 'sagemath:develop' into arrangements
enriqueartal Dec 19, 2023
90e343d
merge conflicts solved
enriqueartal Dec 26, 2023
281aa76
changes from review
enriqueartal Dec 28, 2023
6f55218
forgotten change
enriqueartal Dec 28, 2023
2fa5790
tex issue
enriqueartal Dec 28, 2023
c221ea5
more review changes
enriqueartal Dec 28, 2023
5f664ae
more relevant codecov warnings in ordered_arrangement
enriqueartal Dec 28, 2023
42fd46c
relevant codecov in plane_curve_arrangement
enriqueartal Dec 29, 2023
45df0a5
more codecov
enriqueartal Dec 29, 2023
416df49
typo
enriqueartal Dec 29, 2023
2b2857f
more changes from review
enriqueartal Dec 29, 2023
830a006
forgot some changes
enriqueartal Dec 29, 2023
580bdc0
errors in :meth:
enriqueartal Dec 29, 2023
7e76fd0
typo
enriqueartal Dec 29, 2023
3140834
more reviewer changes
enriqueartal Jan 1, 2024
d32de82
more reviewer changes
enriqueartal Jan 6, 2024
2431c6b
change tuple to frozenset
enriqueartal Jan 6, 2024
cd9ecd7
set puiseux True and do not change simplified to False
enriqueartal Jan 6, 2024
630e0cf
attributes as dictionaries
enriqueartal Jan 8, 2024
1c1c30c
delete commented lines
enriqueartal Jan 8, 2024
a896c65
adapt attributes in ordered_arrangement
enriqueartal Jan 9, 2024
74441b2
Merge branch 'sagemath:develop' into arrangements
enriqueartal Jan 14, 2024
c3a8ada
Merge branch 'sagemath:develop' into arrangements
enriqueartal Jan 22, 2024
c57aec8
Merge branch 'sagemath:develop' into arrangements
enriqueartal Feb 3, 2024
2e472d4
attributes are not dictionaries
enriqueartal Feb 8, 2024
73a728d
change attributes in arrangement code
enriqueartal Feb 8, 2024
3cbafec
changes following #37281
enriqueartal Feb 11, 2024
97ee135
underscores and other details
enriqueartal Feb 13, 2024
f5e412f
merge
enriqueartal Feb 14, 2024
f556fbf
merge develop
enriqueartal Feb 25, 2024
b7b70a9
Merge branch 'sagemath:develop' into arrangements
enriqueartal Mar 1, 2024
d98325a
Merge branch 'sagemath:develop' into arrangements
enriqueartal Mar 5, 2024
5688d68
reviewer's comments
enriqueartal Mar 8, 2024
9cff70b
Merge branch 'sagemath:develop' into arrangements
enriqueartal Mar 10, 2024
f83cf48
first merge of plane curve arrangement classes
enriqueartal Mar 11, 2024
50cfa19
fixing doctests for the new class
enriqueartal Mar 12, 2024
f112bf9
Merge branch 'sagemath:develop' into arrangements
enriqueartal Mar 17, 2024
d724267
more reviewer changes
enriqueartal Mar 21, 2024
74ae1c9
indentation problem
enriqueartal Mar 21, 2024
25e8be4
Merge branch 'sagemath:develop' into arrangements
enriqueartal Mar 26, 2024
5b047bf
check abstract_method
enriqueartal Mar 26, 2024
61a4f66
check abstract_method 2
enriqueartal Mar 26, 2024
5b6ba8c
tests and one more abstract method: change_ring
enriqueartal Mar 26, 2024
816cf87
reviewer changes
enriqueartal Mar 31, 2024
28cd23e
merge
enriqueartal Apr 1, 2024
7f28f0c
more reviewer comments
enriqueartal Apr 9, 2024
03b5444
change method change_ring to keep equal objects
enriqueartal Apr 9, 2024
279a200
Merge branch 'sagemath:develop' into arrangements
enriqueartal Apr 9, 2024
8bb020e
first try to solve merge conflict with develop
enriqueartal Apr 13, 2024
0339378
minimal intervention in all.py files
enriqueartal Apr 15, 2024
638fe01
deal with all.py conflicts
enriqueartal Apr 25, 2024
ff9cfd6
merge 10.4beta
enriqueartal Apr 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/doc/en/reference/curves/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Curves
sage/schemes/curves/constructor
sage/schemes/curves/curve
sage/schemes/curves/affine_curve
sage/schemes/curves/plane_curve_arrangement
sage/schemes/curves/projective_curve
sage/schemes/curves/point
sage/schemes/curves/closed_point
Expand Down
1 change: 1 addition & 0 deletions src/doc/en/reference/discrete_geometry/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Hyperplane arrangements
:maxdepth: 1

sage/geometry/hyperplane_arrangement/arrangement
sage/geometry/hyperplane_arrangement/ordered_arrangement
sage/geometry/hyperplane_arrangement/library
sage/geometry/hyperplane_arrangement/hyperplane
sage/geometry/hyperplane_arrangement/affine_subspace
Expand Down
1 change: 1 addition & 0 deletions src/sage/geometry/all.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
lazy_import('sage.geometry.voronoi_diagram', 'VoronoiDiagram')
lazy_import('sage.geometry.ribbon_graph', 'RibbonGraph')
lazy_import('sage.geometry.hyperplane_arrangement.arrangement', 'HyperplaneArrangements')
lazy_import('sage.geometry.hyperplane_arrangement.ordered_arrangement', 'OrderedHyperplaneArrangements')
lazy_import('sage.geometry.hyperplane_arrangement.library', 'hyperplane_arrangements')
152 changes: 88 additions & 64 deletions src/sage/geometry/hyperplane_arrangement/arrangement.py

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/sage/geometry/hyperplane_arrangement/library.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def bigraphical(self, G, A=None, K=QQ, names=None):
for u, v in G.edge_iterator(labels=False, sort_vertices=False):
i = vertex_to_int[u]
j = vertex_to_int[v]
hyperplanes.append( x[i] - x[j] - A[i][j])
hyperplanes.append(x[i] - x[j] - A[i][j])
hyperplanes.append(-x[i] + x[j] - A[j][i])
return H(*hyperplanes)

Expand Down Expand Up @@ -794,7 +794,7 @@ def Shi(self, data, K=QQ, names=None, m=1):
hyperplanes = []

for a in PR:
for const in range(-m+1,m+1):
for const in range(-m + 1, m + 1):
hyperplanes.append(sum(a[j]*x[j] for j in range(d))-const)
A = H(*hyperplanes)
x = polygen(QQ, 'x')
Expand Down
Loading
Loading