This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Started work on making atl build cross platform #268
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
As discussed in #266 I wanted to help getting atl building cross platform. This PR starts that. Things to note:
build
script; it should have readrm -rf dist
but actually readrm -rf dict
. I've corrected that and replacedrm -rf
withrimraf
as it's cross platform. Handily it was already a project dependencysourceamps
should have beensourcemaps
. Now it isI haven't looked at the tests yet and so there may be an obvious reason why this test is failing. I'm out of time for now. Any thoughts?
Prob doesn't make sense to merge this PR until the failing test is resolved but I thought I'd share where I'd got so far.