Call main only once take 4 #3236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready now @Liamolucko. |
daxpedda
added a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
Jan 19, 2023
* Modify `module.start` instead of wrapping it * Call main only once
chemicstry
added a commit
to chemicstry/wasm_thread
that referenced
this pull request
Mar 10, 2023
wasm-bindgen no longer autostarts main on worker threads: rustwasm/wasm-bindgen#3236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3092, this addresses the possible race condition if one doesn't use
initwhen compiling the WASM module.To make this possible I changed the way the start function was modified in various places.
Currently the start function was always taken from the module and then wrapped into a new function, constructing a pretty nested start function.
With this PR the start function is constantly being modified instead of wrapping it over and over again, this allows to use local variables, eg. I stored the current thread counter in a local variable that I can use later to determine if we are in the first thread or not.
I hope it's alright that I put some shared functionality into
wasm-bindgen-wasm-conventions.Replaces #3062, #3092 and #3234.
Fixes #2295.