Skip to content

Eagerly implemented PartialEq and Eq traits #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rynibami
Copy link
Contributor

Issue #340 discussed implementing the most common traits for this crate. I implemented the PartialEq and Eq traits for all possible stucts and enums in this PR. I included the derive for private key data as I thought that this would not leak any secret information. Please correct me if I'm wrong.

@djc
Copy link
Member

djc commented May 18, 2025

I don't think we should implement these in rustls-cert-gen which I don't consider as having a public Rust API anyway.

@Rynibami
Copy link
Contributor Author

I don't think we should implement these in rustls-cert-gen which I don't consider as having a public Rust API anyway.

@djc I reverted all Eq and PartialEq I made to rustls-cert-gen. Are there more things that should be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants