Skip to content

Remove unnecessary underscore from impl<T, const N: usize> Distribution<[T; N]> for StandardUniform #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

sorairolake
Copy link
Contributor

  • Added a CHANGELOG.md entry

Summary

Remove the leading underscore from the _rng parameter of the sample method.

Motivation

Because this parameter appears to be used. I think suppressing the unused_variables lint is unnecessary.

@sorairolake sorairolake deleted the remove-underscore branch February 12, 2025 13:47
@sorairolake sorairolake restored the remove-underscore branch February 12, 2025 14:55
@sorairolake sorairolake reopened this Feb 12, 2025
@benjamin-lieser
Copy link
Member

This has nothing to do with the removed underscore, because the current master also fails now.
Something has changed with the nightly compiler which breaks our code.

Do you want to investigate this? If not I can do it and would put commits on this branch.

@benjamin-lieser
Copy link
Member

So std::simd added their own extract function which gets called instead of our own helper, that why it fails.

@sorairolake
Copy link
Contributor Author

@benjamin-lieser

If not I can do it and would put commits on this branch.

Thanks. I agree to fix the broken code and commits it to this branch.

@benjamin-lieser
Copy link
Member

I have opened a different pull request for this issue #1586 , if this gets merged, you can rebase and this should then also work.

@benjamin-lieser benjamin-lieser merged commit 06b1642 into rust-random:master Feb 13, 2025
15 checks passed
@sorairolake sorairolake deleted the remove-underscore branch February 13, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants