allocator: Use appropriate memory types #804
Conversation
|
Thanks for the contribution! I see why this is beneficial and probably this is the right thing to do. Could you please briefly explain the high-level use case you are working on? I'm curious in what scenario this was a problem. All I can think of at the moment is that you were installing a custom boot service driver and you want that memory to be freed when boot services are exited? PS: Plz fix the CI warnings. |
| @@ -22,6 +23,9 @@ use crate::table::boot::{BootServices, MemoryType}; | |||
| /// exited by the host application yet. | |||
| static mut BOOT_SERVICES: Option<NonNull<BootServices>> = None; | |||
|
|
|||
| /// The memory type used for pool memory allocations. | |||
| static mut MEMORY_TYPE: MemoryType = MemoryType::LOADER_DATA; | |||
There was a problem hiding this comment.
Hm, I'd like to have the Once type here but it is a nightly-only API so far (https://doc.rust-lang.org/core/cell/struct.OnceCell.html).
Could you at least add a comment that this value is supposed to be set once during initialization and never altered again?
Boot/runtime driveres generally only want to allocate with their respective memory types. Using the wrong allocation types or mixing them can result in hard to debug issues (when loading linux).
|
I'm actually not doing anything with this. I've been hit by mixed allocations in sd-boot and just think that uefi-rs should try to avoid this. (It's also what gnu-efi does for its |
No description provided.