Skip to content

Drop explicit enabling of abi_efiapi feature #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/msrv_toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[toolchain]
# Oldest nightly that currently works with `cargo xtask build`.
channel = "nightly-2022-08-25"
channel = "nightly-2023-01-14"
components = ["rust-src"]
4 changes: 1 addition & 3 deletions book/src/tutorial/app.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ This is some boilerplate that all Rust UEFI applications will
need. `no_main` is needed because the UEFI application entry point is
different from the standard Rust `main` function. `no_std` is needed to
turn off the `std` library; the `core` and `alloc` crates can still be
used. And `feature(abi_efiapi)` is needed because UEFI applications have
a special calling convention that is not yet stabilized in the Rust
compiler.
used.

Next up are some `use` lines. Nothing too exciting here; the
`uefi::prelude` module is intended to be glob-imported, and exports a
Expand Down
2 changes: 0 additions & 2 deletions template/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#![no_main]
#![no_std]
#![feature(abi_efiapi)]
#![allow(stable_features)]

use uefi::prelude::*;

Expand Down
1 change: 0 additions & 1 deletion uefi-macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ fn get_function_arg_name(f: &ItemFn, arg_index: usize, errors: &mut TokenStream2
/// ```no_run
/// #![no_main]
/// #![no_std]
/// #![feature(abi_efiapi)]
/// # // A bit of boilerplate needed to make the example compile in the
/// # // context of `cargo test`.
/// # #![feature(lang_items)]
Expand Down
2 changes: 0 additions & 2 deletions uefi-services/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@

#![no_std]
#![feature(alloc_error_handler)]
#![feature(abi_efiapi)]
#![deny(clippy::must_use_candidate)]
#![allow(stable_features)]

extern crate log;
// Core types.
Expand Down
2 changes: 0 additions & 2 deletions uefi-test-runner/examples/hello_world.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// ANCHOR: features
#![no_main]
#![no_std]
#![feature(abi_efiapi)]
#![allow(stable_features)]
// ANCHOR_END: features

// ANCHOR: use
Expand Down
2 changes: 0 additions & 2 deletions uefi-test-runner/examples/loaded_image.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// ANCHOR: all
#![no_main]
#![no_std]
#![feature(abi_efiapi)]
#![allow(stable_features)]

use log::info;
use uefi::prelude::*;
Expand Down
2 changes: 0 additions & 2 deletions uefi-test-runner/examples/sierpinski.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// ANCHOR: all
#![no_main]
#![no_std]
#![feature(abi_efiapi)]
#![allow(stable_features)]

extern crate alloc;

Expand Down
2 changes: 0 additions & 2 deletions uefi-test-runner/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#![no_std]
#![no_main]
#![feature(abi_efiapi)]
#![allow(stable_features)]

#[macro_use]
extern crate log;
Expand Down
2 changes: 0 additions & 2 deletions uefi/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
//! [`uefi-services`]: https://crates.io/crates/uefi-services
//! [unstable features]: https://doc.rust-lang.org/unstable-book/

#![feature(abi_efiapi)]
#![cfg_attr(feature = "unstable", feature(error_in_core))]
#![cfg_attr(all(feature = "unstable", feature = "alloc"), feature(allocator_api))]
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
Expand All @@ -67,7 +66,6 @@
#![warn(clippy::ptr_as_ptr, missing_docs, unused)]
#![deny(clippy::all)]
#![deny(clippy::must_use_candidate)]
#![allow(stable_features)]

#[cfg(feature = "alloc")]
extern crate alloc;
Expand Down