Implement Error and Display traits for FromStrError

[raccog]

For issue #594.

I implemented the Error trait in the same way that it's implemented for uefi::Error.

I'm not sure where the Error trait is useful, so I haven't tested it beyond running the unit/qemu tests. :P I'm curious, though, what can this be used for?

Please let me know if this looks like a good solution for #594 and I'll implement these traits for other error types, as well.

Checklist

• Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
• Update the changelog (if necessary)

[phip1611]

I implemented the Error trait in the same way that it's implemented for uefi::Error.

Very good, this is a good contribution! thanks!

I'm not sure where the Error trait is usefu

If you want to integrate the errors with the anyhow crate, for example.

[phip1611]

@nicholasbishop I think we should find a solution to guarantee consistency. Either we use derive_more::Display for errors or the display impl should fall back to the Debug impl. What do you think?

[nicholasbishop]

I think having Debug and Display be different is fine, with the general convention that Debug should be a bare-bones representation of the type, and Display should be human readable.

For example, in Rust's std, Utf8Error follows this pattern. It has derive(Debug) and an impl Derive that manually provides a more human-readable string.

[phip1611]

ok

[raccog]

If you want to integrate the errors with the anyhow crate, for example.

Thanks for the tip, that crate looks interesting!