Implement Error trait for uefi::Error #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
requested changes
Nov 26, 2022
This is useful to integrate with error handling libaries, such as anyhow.
... to enable error_in_core feature.
| @@ -41,6 +41,7 @@ | |||
| #![feature(maybe_uninit_slice)] | |||
| #![feature(negative_impls)] | |||
| #![feature(ptr_metadata)] | |||
| #![feature(error_in_core)] | |||
There was a problem hiding this comment.
As discussed in another PR, we're going to want to gate new unstable features behind an unstable feature in the UEFI crate: https://github.com/rust-osdev/uefi-rs/pull/584/files#r1031848552
However, we haven't merged in the new feature gate yet, so I think I'll go ahead and merge this PR, and update #590 to put this behind the unstable fate.
nicholasbishop
approved these changes
Nov 27, 2022
|
Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use error-handling crates, such as anyhow, the
uefi::Errortype needs to implement theErrortrait.To do this, I had to bump the minimum nightly version a couple of days to enable the
error_in_corefeature.Checklist