Skip to content

TryFrom<core::ffi::CStr> implementation for CStr8 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

TryFrom<core::ffi::CStr> implementation for CStr8 #581

merged 1 commit into from
Nov 23, 2022

Conversation

phip1611
Copy link
Member

After this was reverted in 5f4e158, we now can add it again, as our MSRV is now recent enough.

This reverts #509 and closes #510

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
TryFrom<core::ffi::CStr> implementation for CStr8
ceb6879 
After this was reverted in 5f4e158, we now can
add it again, as our MSRV is now recent enough.
@nicholasbishop nicholasbishop merged commit 8c070c7 into rust-osdev:main Nov 23, 2022
@phip1611 phip1611 deleted the cstr-ffi branch April 2, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert temporary revert #509
2 participants
@phip1611 @nicholasbishop