Skip to content

test-runner: Consistently use global image handle #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

test-runner: Consistently use global image handle #1189

merged 1 commit into from
Jun 11, 2024

Conversation

nicholasbishop
Copy link
Member

Rather than passing the image handle around in function args, just use the global image handle.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop nicholasbishop requested a review from phip1611 June 9, 2024 00:36
@nicholasbishop @phip1611
test-runner: Consistently use global image handle
924d1da 
Rather than passing the image handle around in function args, just use the
global image handle.
@phip1611 phip1611 force-pushed the bishop-handle-cleanup branch from a319906 to 924d1da Compare June 11, 2024 16:39
@phip1611 phip1611 enabled auto-merge June 11, 2024 16:39
@phip1611 phip1611 added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 99a2433 Jun 11, 2024
15 checks passed
@phip1611 phip1611 deleted the bishop-handle-cleanup branch June 11, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 Awaiting requested review from phip1611

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611