Skip to content

uefi: BootServices::allocate_pool now returns NonZero<u8> instead of *mut u8 #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2024
Merged

uefi: BootServices::allocate_pool now returns NonZero<u8> instead of *mut u8 #1176

merged 1 commit into from
May 27, 2024

Conversation

phip1611
Copy link
Member

This is safe as each null pointer (=failed allocation) is already returned as non-successful status code by UEFI.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
uefi: BootServices::allocate_pool now returns NonZero<u8> instead of …
2f4aece 
…*mut u8

This is safe as each null pointer (=failed allocation) is already returned as
non-successful status code by UEFI.
@phip1611 phip1611 requested a review from nicholasbishop May 25, 2024 14:00
@nicholasbishop nicholasbishop added this pull request to the merge queue May 27, 2024
Merged via the queue into rust-osdev:main with commit 1918bd3 May 27, 2024
12 checks passed
@phip1611 phip1611 deleted the allocate-pool branch May 27, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phip1611 @nicholasbishop