Deprecate uefi-services and add uefi::helpers as replacement
#1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
remove-uefi-services
branch
3 times, most recently
from
6ec25e5 to
1829dca
Compare
phip1611
force-pushed
the
remove-uefi-services
branch
2 times, most recently
from
b5625fb to
c21e56b
Compare
phip1611
changed the title
uefi-services and add uefi::helpers as replacement
phip1611
force-pushed
the
remove-uefi-services
branch
4 times, most recently
from
c77cf23 to
2e45e42
Compare
phip1611
force-pushed
the
remove-uefi-services
branch
from
2e45e42 to
905baa6
Compare
uefi_services::init temporarily stays API compatible to prevent breaking changes. But we've added deprecation warnings. The new uefi::helpers module consists mostly of an unchanged code import. Only minor adjustments were applied. Cleanup will happen in a follow-up.
Note that even without these changes, everything works. This proves that we stay API compatible for the next uefi-services release.
I didn't change anything about the implementations, just moved the existing code into the corresponding modules.
phip1611
force-pushed
the
remove-uefi-services
branch
2 times, most recently
from
9ef222d to
19629e3
Compare
|
I've taken care of all your comments. Please re-review. |
No need for the complicated and error-prone approach using an event.
phip1611
force-pushed
the
remove-uefi-services
branch
from
19629e3 to
9a257a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #563, we deprecated uefi-services and move it to a new
uefi::helpersmodule.uefi-servicesis marked as deprecateduefi_services::initforwards touefi::helpers::init(drop-in replacement!)uefi::helpers::initnow takes care of everythingHints for Reviewers
uefi_services::inittouefi::helpers::initworks, I'm suggesting to temporarily revertuefi-test-runner: use new uefi::helpers module- or you can just trust me. :)Checklist