Add numeric functions and traits that provide numeric traits for generic mathematics. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure will be fixed by nightly build updates. |
gifnksm
changed the title
|
Now. travis passed with latest nightly build. |
… for generic mathematcs. Import numeric traits and functions that were removed from the standard library. This also implements `AdditiveIterator` and `MultiplicativeIterator` for `BigUint` and `BigInt`. closes #28
The codes are imported from the standard library.
|
@bjz You might want to comment on this. My perception is that the existing traits were not really an ideal design for generic programming over numerics (and that in general there are problems trying to be generic over "true" mathematical abstractions and primitives types at the same time). |
|
Yeah I'm not sure. It would definitely need a re-think later. I am currently working on an abstract algebra library at https://github.com/bjz/algebra |
alexcrichton
added a commit
that referenced
this pull request
Nov 17, 2014
Add numeric functions and traits that provide numeric traits for generic mathematics.
remexre
pushed a commit
to remexre/num
that referenced
this pull request
Jun 1, 2017
This resolves rust-num#22, resolves rust-num#29, and resolves rust-num#30. * The reported error code is now `MissingField`, not `ExpectedSomeValue`. * A missing `()` field now causes a `MissingField` error. * A missing `Vec<_>` field now causes a `MissingField` error. Tests have been updated to check these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following modules and functions.
traitsmodule that provides numeric traits, such asZero,One,Boundeditermodule that provides genericrangeiteratorsstd::num, such asone,zeroThe codes are imported from old rust standard library.
closes #28