-
Notifications
You must be signed in to change notification settings - Fork 323
Add ndarray for NumPy users doc #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ndarray for NumPy users doc #421
Conversation
@jturner314 I really like this. I do agree that a giant table might not be a best way to convey the information at once. Array Indexing; I feel like examples could be nice to have, but I would definitely say what you have right now is a great start for those of us coming over from other languages. I'll see if I can't come up with a few examples this weekend when I have some more time that could potentially go in here. Also, one thing that I might like to see added is just a simple mention for how to create a Fortran memory layout array. While it didn't take me too long to find in the docs, I think it'd be nice to have it just listed here as well. |
f5a23f3
to
04fcd30
Compare
I added some more stuff and reorganized the big table into sections. (rendered here) Any thoughts? @rcarson3 That would be awesome if you have any examples to include. Would some discussion of |
@jturner314 I think the current setup is fine. I don't know if discussions on I've written some The equivalent If you can think of any other common features that might be useful to include let me know, and I'll iterate on these a bit more. I'm not sure if the best place to put them would be in the document just due to length, but maybe they could go in the examples folder. I currently just have them hosted on my repo I made to learn Rust, but I can just as easily make a pull request on your ndarray-for-numpy-users branch for the examples as well. |
a6fe652
to
c08c58f
Compare
Yeah, I think it makes the most sense to put the example(s) in the
Will you please submit a PR to my I added another section to the |
That's really great work. For C & C on the document, I'd like us to be clear in the style / algorithms we promote. From the top.
Instead of current Slices are fine, the range dots are usually cuddled even when using spaces. So the style would prefer this: There's an unqualified Where we mention For Some things we can add:
I don't know if we should avoid mentioning |
In the spirit of style, I think I'd skip |
73d4ec9
to
81e6efd
Compare
Okay, I changed those things. I also did the following:
The examples maybe could use a little more description or reorganization, but I think they're good enough for the time being. Everything else seems pretty good. You can view the docs by running What do you think? Is this ready to merge? (I'll clean up the commit history first.) |
Yes, it's ready for merge. It looks great! |
(Feel free to merge when you have rebased it) |
4873b8d
to
f843e0f
Compare
I forgot to remove these annotations before merging rust-ndarray#421. They were necessary until after rust-ndarray#422 was merged.
🥇 fantastic! |
Motivated by @rcarson3 in #419, I put together an initial "
ndarray
for NumPy users" document (rendered here). It needs more stuff added (maybe some examples solving the same problems with NumPy andndarray
?), and I'm not convinced that a big table is the best way to organize things, but it's a start.@rcarson3 What do you think so far?
Where's the best place to put this? Just host it on GitHub at
bluss/rust-ndarray
and link to it from the README and docs, or is there a good way to put it on its own page in the docs themselves?Fixes #399