Skip to content

feat: support for parsing beta versions with tags in the toolchain #3858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

roife
Copy link
Member

@roife roife commented Jun 4, 2024

Fix #1329.

This PR adds support for parsing toolchain names which containing beta channel and tags (like 1.23-beta, 1.23.0-beta or 1.23.0-beta.2).

Changes

  • Add support for parsing beta versions with tags in the toolchain names and corresponding unit tests.
  • Add scenario BetaTag and mock data.
  • Add regression tests.

@roife roife force-pushed the parsing-beta-version-with-tags branch 2 times, most recently from eacd591 to 261f248 Compare June 4, 2024 08:43
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@roife roife force-pushed the parsing-beta-version-with-tags branch from 261f248 to 6fdf97e Compare June 4, 2024 09:15
@rami3l rami3l enabled auto-merge June 4, 2024 09:17
@rami3l rami3l added this pull request to the merge queue Jun 4, 2024
Merged via the queue into rust-lang:master with commit 6d43761 Jun 4, 2024
24 checks passed
@rami3l rami3l added this to the 1.28.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading specific betas should be easier
2 participants