Skip to content

dist: Ensure we treat two-part versions as tracking #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

kinnison
Copy link
Contributor

Without this, rustup update will not update two-part version channels such as 1.48.

This is a necessary extension of #2551

Without this, `rustup update` will not update two-part version
channels such as `1.48`.

Signed-off-by: Daniel Silverstone (WSL2) <[email protected]>
@kinnison kinnison added this to the 1.23.0 milestone Nov 21, 2020
@kinnison
Copy link
Contributor Author

I cannot release 1.23.0 of rustup claiming to support two-part versions unless we merge this I think.

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, I didn't realize this needed to be changed too ❤️

@kinnison kinnison merged commit 54d8296 into rust-lang:master Nov 23, 2020
@kinnison kinnison deleted the update-two-part-versions branch November 23, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants