Skip to content

Treat time in seconds as an integer for download times #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2019
Merged

Treat time in seconds as an integer for download times #1699

merged 1 commit into from
Mar 10, 2019

Conversation

Manishearth
Copy link
Member

We use / and % in a way that assumes it's an integer.

fixes #1696

@Manishearth Manishearth mentioned this pull request Mar 9, 2019
Closed
kinnison
kinnison approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dwijnand do you concur?

dwijnand
dwijnand approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@dwijnand dwijnand merged commit 94cc341 into rust-lang:master Mar 10, 2019
@kinnison kinnison mentioned this pull request Mar 18, 2019
Closed
@toothbrush7777777 toothbrush7777777 mentioned this pull request Mar 29, 2019
Closed
@kinnison kinnison mentioned this pull request Apr 9, 2019
Closed
@nrc nrc mentioned this pull request Apr 14, 2019
Closed
@memoryruins memoryruins mentioned this pull request Apr 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustup-Init displays ETA with lots of decimal places
3 participants
@Manishearth @dwijnand @kinnison