Overlong function signature

[nrc]

    pub unsafe fn reborrow_mut(&mut self) -> Handle<NodeRef<marker::Mut, K, V, NodeType>, HandleType> {

[nrc]

Another example:

    pub fn merge(mut self) -> Handle<NodeRef<marker::Mut<'a>, K, V, marker::Internal>, marker::Edge> {

[marcusklaas]

How is this possible?

[brson]

Since this is tagged easy, how might one go about fixing it (and #1048)?

[nrc]

I would start here: https://github.com/rust-lang-nursery/rustfmt/blob/master/src/items.rs#L1221 and insert a bunch of printlns (or use a debugger) to figure out the path the code is taking and the widths being passed down to the helper functions, at some point it should be clear that a helper is being asked to format into a width that is one larger than it ought to be. Whilst not being a lot of fun, this is usually quite easy to figure out. Exactly how to fix it depends on what the problem looks like. It might be as simple as adding a constant 1 to something.

[jefftt]

whoops sorry made a mistake.

Hi! I'm new to rust and took at shot that this issue.

[brson]

@juicejitsu Great! @nrc can you help @juicejitsu land this fix? Looks like they've got a patch ready to go.

[fabric-and-ink]

@juicejitsu I had the same idea like you but there are at least two corner cases which have to be considered. Please have a look at #1089. Maybe you want to finish that PR? Sadly I have nearly no spare time right now...

[jefftt]

@dawirstejeck Sure! Taking a look

[fabric-and-ink]

This can be closed now, right?