This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Custom warning when rustfix replacing fails #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rustfix fails to replace a chunk of code, we now display a similar warning than when we "fixed" the code so that it no longer compiles. Previously, when rustfix fails to apply suggestions to a file, we bailed out of the whole loop over all the files in the current target. Instead, we'll now log a nice error message. (I'm not sure if that is a good idea but we will revert non-compiling changes later on anyway.)
killercup
commented
May 6, 2018
| //! Ensure we give good error message when rustfix failes to apply changes | ||
| //! | ||
| //! TODO: Add rustc shim that outputs wrong suggestions instead of depending on | ||
| //! actual rustc bugs! |
There was a problem hiding this comment.
rust-lang/rust#50472 will break the test in this file :)
|
Looks great! We'll figure out to do once the upstream bug is fixed :) |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rustfix fails to replace a chunk of code, we now display a
similar warning than when we "fixed" the code so that it no longer
compiles.
Previously, when rustfix fails to apply suggestions to a file, we bailed
out of the whole loop over all the files in the current target. Instead,
we'll now log a nice error message. (I'm not sure if that is a good idea
but we will revert non-compiling changes later on anyway.)