Add traits SLG solver section #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe we want to include this in the bibliography or something, though.
|
I don't have any objections. |
mark-i-m
suggested changes
Nov 10, 2018
|
Waiting on rust-lang/chalk#190 to be merged so I can link to some methods. |
|
Okay, this should be ready. |
mark-i-m
approved these changes
Nov 20, 2018
|
@tmandry r=me :) Should I wait for Niko? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just an adapted version of Niko's blog post.
From here we need to add a subsection on negative reasoning, and possibly one on how the solver handles regions. Also one on using the solver via the
Contextand related traits.cc @nikomatsakis @scalexm