Polish lowering chapters and update rules #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalexm
force-pushed
the
update-lowering
branch
from
37193ef to
e074d40
Compare
scalexm
force-pushed
the
update-lowering
branch
from
e074d40 to
e028ac2
Compare
mark-i-m
suggested changes
Oct 19, 2018
There was a problem hiding this comment.
Nice! Thanks for your continued maintenance of this chapter 😄
I left some comments/suggestions, but overall, LGTM!
I think you missed one:
The given associated type
Projectionis equal toType; this can be proved
with either normalization or using skolemized types.
(line 120, under ProjectionEq(Projection = Type) in goals-and-clauses.md)
Also, left a few suggestions using GitHub's new suggestions feature... let me know if that works, so I know whether to keep using it or not.
src/traits/goals-and-clauses.md
Outdated
| | Outlives(Type: Region) | ||
| | Outlives(Region: Region) | ||
| ``` | ||
|
|
||
| `WhereClause` refers to a `where` clause that a Rust user would actually be able | ||
| to write in a Rust program. This abstraction exists only as a convenience as we | ||
| sometimes want to only coope with domain goals that are effectively writable in |
There was a problem hiding this comment.
I wanted to write « cope with » I guess, but now I realize I don’t know if it’s an appropriate verb to use in this context
Co-Authored-By: scalexm <[email protected]>
Co-Authored-By: scalexm <[email protected]>
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated a bit the lowering-to-logic chapters. In particular, I changed the name of two logical rules: I'll adjust documentation accordingly in rustc and chalk. The implied bounds chapter still needs to be written (which I'm currently doing).