Improve terse test output. #95709
Improve terse test output. #95709
Conversation
The current terse output gives 112 chars per line, which causes wraparound for people using 100 char wide terminals, which is very common. This commit changes it to be exactly 100 wide, which makes the output look much nicer.
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Before: After: I have been seeing this output for years, but had never thought about how it was wrapping, until today when I ran the tests in a wider than usual terminal window and immediately saw how much better it looked. The only downside of the change is that the increments are now 88 instead of 100. Less intuitive, but luckier :) |
|
I wonder if instead of using a magic number to determine how many test cases to display in a line, perhaps we could detect the terminal size and change the number of test cases in a row to match? |
Quite possibly, but that takes us into perfect-is-the-enemy-of-good territory. A follow-up? |
|
@bors rollup=always |
|
@bors r+ rollup |
|
📌 Commit b72a7fb has been approved by |
bors
added
S-waiting-on-bors
Rollup of 5 pull requests Successful merges: - rust-lang#95185 (Stabilize Stdin::lines.) - rust-lang#95626 (Don't cast thread name to an integer for prctl) - rust-lang#95709 (Improve terse test output.) - rust-lang#95735 (Revert "Mark Location::caller() as #[inline]") - rust-lang#95738 (Switch item-info from div to span) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The current terse output gives 112 chars per line, which causes
wraparound for people using 100 char wide terminals, which is very
common.
This commit changes it to be exactly 100 wide, which makes the output
look much nicer.