Add link to closed PR for future optimizers of ChunkedBitSet relations #94709
Conversation
While optimizing these operations proved unfruitful w.r.t. improving compiler performance right now, faster versions might be needed at a later time.
rustbot
added
the
T-compiler
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nnethercote (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Lovely, thank you. @bors r+ rollup |
|
📌 Commit 4d38f15 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (89adcc6): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
| // improved, but it hasn't been a problem in practice so far. | ||
| // FIXME: This is slow if `other` is dense, but it hasn't been a problem | ||
| // in practice so far. | ||
| // If a a faster implementation of this operation is required, consider |
There was a problem hiding this comment.
tiny typo here and below
| // If a a faster implementation of this operation is required, consider | |
| // If a faster implementation of this operation is required, consider |
There was a problem hiding this comment.
Ah, that's stupid, thanks for catching it! Fixes in #94956
While optimizing these operations proved unfruitful w.r.t. improving compiler performance right now, faster versions might be needed at a later time. This PR adds a link in the FIXME to save any future optimizers some time, as requested by @nnethercote in #94625.
r? @nnethercote