-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Avoid generating QueryMap::extend for each key type #84805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 61fd56f with merge b4044d2852213f861e5f50ff61ed350034e92f09... |
☀️ Try build successful - checks-actions |
Queued b4044d2852213f861e5f50ff61ed350034e92f09 with parent 4de7572, future comparison URL. |
Finished benchmarking try commit (b4044d2852213f861e5f50ff61ed350034e92f09): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit 61fd56f has been approved by |
☀️ Test successful - checks-actions |
Should be a small win on compile times for rustc_query_impl, where this ends up getting codegen'd.