Skip to content

Avoid generating QueryMap::extend for each key type #84805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2021

Conversation

Mark-Simulacrum
Copy link
Member

Should be a small win on compile times for rustc_query_impl, where this ends up getting codegen'd.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2021
@bors
Copy link
Collaborator

bors commented May 2, 2021

⌛ Trying commit 61fd56f with merge b4044d2852213f861e5f50ff61ed350034e92f09...

@bors
Copy link
Collaborator

bors commented May 2, 2021

☀️ Try build successful - checks-actions
Build commit: b4044d2852213f861e5f50ff61ed350034e92f09 (b4044d2852213f861e5f50ff61ed350034e92f09)

@rust-timer
Copy link
Collaborator

Queued b4044d2852213f861e5f50ff61ed350034e92f09 with parent 4de7572, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b4044d2852213f861e5f50ff61ed350034e92f09): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2021
@cjgillot cjgillot self-assigned this May 2, 2021
@cjgillot
Copy link
Contributor

cjgillot commented May 2, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented May 2, 2021

📌 Commit 61fd56f has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2021
@bors
Copy link
Collaborator

bors commented May 2, 2021

⌛ Testing commit 61fd56f with merge 3a1cd0e...

@bors
Copy link
Collaborator

bors commented May 2, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 3a1cd0e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 2, 2021
@bors bors merged commit 3a1cd0e into rust-lang:master May 2, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 2, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the no-dup-extend branch May 2, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants