UDP and TCP methods should take &mut self to reflect that libuv may change the underlying handle. #7892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflect that libuv may change the underlying handle.
|
r? @brson |
|
The pull request of incomplete so I closed and resubmitted. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
Disable "if_not_else" lints from firing on else-ifs Fixes rust-lang#7892 1. Convert `['if_not_else']` to `LateLintPass` and use `clippy_utils::is_else_clause` for checking. 2. Update tests. changelog: [`if_not_else`] now ignores else if statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP methods already did this, but the UDP methods and the socket control functions on TCP/UDP did not.