Skip to content

std::rt: Use a constant 4 threads for multithreaded sched tests. #7772 #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2013

Conversation

brson
Copy link
Contributor

@brson brson commented Jul 17, 2013

Too much overcommit here exhausts the low fd limit on OS X.

@brson
Copy link
Contributor Author

brson commented Jul 19, 2013

@kballard that sounds ok. do you know that it works? on my machine I had to use launchctl to change the global limits before setting the ulimits or else ulimit had no effect.

…-lang#7772

Too much overcommit here exhausts the low fd limit on OS X.
@brson
Copy link
Contributor Author

brson commented Jul 19, 2013

I believe that setrlimit will not allow a process to raise the maximum files above that set by launchd

@lilyball
Copy link
Contributor

@brson Without touching anything on my machine, kern.maxopenfilesperproc is set to 10240. The default 256 limit that command-line programs see isn't set by launchd as far as I can tell, it's either set by Terminal.app or by bash. You can raise it to 10240 with setrlimit(), and you can verify this yourself by opening a new Terminal window and typing ulimit -n 10240.

I have some proof-of-concept code that calls sysctl() to find out the current setting for kern.maxopenfilesperproc and then gives this to setrlimit(), and it works.

bors added a commit that referenced this pull request Jul 20, 2013
Too much overcommit here exhausts the low fd limit on OS X.
@bors bors closed this Jul 20, 2013
@bors bors merged commit 49b72bd into rust-lang:master Jul 20, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 4, 2021
Update CHANGELOG

r? `@xFrednet`  (you showed to be a reliable reviewer for this :) )

[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants