Skip to content

SmallIntMap and SmallIntSet now have external iterators as per Issue #7366 #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SmallIntMap and SmallIntSet now have external iterators as per Issue #7366 #7614

wants to merge 1 commit into from

Conversation

MarkJr94
Copy link
Contributor

@MarkJr94 MarkJr94 commented Jul 6, 2013

Added external iterators as well as tests to SmallIntMap and SmallIntSet. Fixes #7366

@Aatch Aatch mentioned this pull request Jul 6, 2013
Adding iterators for extra::smallintmap

Working on mutability error

Ran into ICE

More mutability problems

Working through mutability issue

working on getting tests passing

SmallIntMa tests passing

Added SmallIntSet iterators, and the tests are passing

Stripped trailing spaces

Removed extra use directive
@alexcrichton
Copy link
Member

It's very rare that you actually type out the entire name of an iterator, so this can probably completely avoid creating extra struct definitions by purely using existing iterator methods to transform the sequence being received from the underlying vector.

bors added a commit that referenced this pull request Jul 9, 2013
Added external iterators as well as tests to SmallIntMap and SmallIntSet. Fixes #7366
@bors bors closed this Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extra::smallintmap needs external iterators
3 participants