Skip to content

Specific error for positional args after named args in format!() #62710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2019

Conversation

estebank
Copy link
Contributor

When writing positional arguments after named arguments in the
format!() and println!() macros, provide a targeted diagnostic.

Follow up to https://github.com/rust-lang/rust/pull/57522/files#r247278885

When writing positional arguments after named arguments in the
`format!()` and `println!()` macros, provide a targeted diagnostic.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2019
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 19, 2019

📌 Commit 33ec182 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2019
@bors
Copy link
Collaborator

bors commented Jul 20, 2019

⌛ Testing commit 33ec182 with merge f69b071...

bors added a commit that referenced this pull request Jul 20, 2019
Specific error for positional args after named args in `format!()`

When writing positional arguments after named arguments in the
`format!()` and `println!()` macros, provide a targeted diagnostic.

Follow up to https://github.com/rust-lang/rust/pull/57522/files#r247278885
@bors
Copy link
Collaborator

bors commented Jul 20, 2019

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing f69b071 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2019
@bors bors merged commit 33ec182 into rust-lang:master Jul 20, 2019
@estebank estebank deleted the bad-named-args branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants