Skip to content

Float 'incomplete_features' out to a const for visibility #60352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 28, 2019

Float let incomplete_features out to a const INCOMPLETE_FEATURES and colocate near active features so that it is easier to find and edit.

r? @oli-obk

(use rollup)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Apr 28, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 28, 2019

📌 Commit 3f30082 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2019
@bors
Copy link
Collaborator

bors commented Apr 28, 2019

⌛ Testing commit 3f30082 with merge bdfdbcd...

bors added a commit that referenced this pull request Apr 28, 2019
Float 'incomplete_features' out to a const for visibility

Float `let incomplete_features` out to a `const INCOMPLETE_FEATURES` and colocate near `active` features so that it is easier to find and edit.

r? @oli-obk

(use rollup)
@bors
Copy link
Collaborator

bors commented Apr 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing bdfdbcd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2019
@bors bors merged commit 3f30082 into rust-lang:master Apr 28, 2019
@Centril Centril deleted the const-incomplete-features branch April 28, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants