Skip to content

rt: don't save and restore xmm/regs in __morestack. #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

rt: don't save and restore xmm/regs in __morestack. #5418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions src/rt/arch/x86_64/morestack.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ MORESTACK:
// Calculate the CFA as on offset from %ebp
.cfi_def_cfa_register %rbp

subq $184, %rsp
subq $56, %rsp

// Save argument registers of the original function
movq %rdi, (%rsp)
Expand All @@ -58,14 +58,6 @@ MORESTACK:
movq %rcx, 24(%rsp)
movq %r8, 32(%rsp)
movq %r9, 40(%rsp)
movdqa %xmm0, 48(%rsp)
movdqa %xmm1, 64(%rsp)
movdqa %xmm2, 80(%rsp)
movdqa %xmm3, 96(%rsp)
movdqa %xmm4, 112(%rsp)
movdqa %xmm5, 128(%rsp)
movdqa %xmm6, 144(%rsp)
movdqa %xmm7, 160(%rsp)

// Calculate the address of the stack arguments.
// We have the base pointer, __morestack's return address,
Expand Down Expand Up @@ -96,16 +88,8 @@ MORESTACK:
movq 24(%rsp), %rcx
movq 32(%rsp), %r8
movq 40(%rsp), %r9
movdqa 48(%rsp), %xmm0
movdqa 64(%rsp), %xmm1
movdqa 80(%rsp), %xmm2
movdqa 96(%rsp), %xmm3
movdqa 112(%rsp), %xmm4
movdqa 128(%rsp), %xmm5
movdqa 144(%rsp), %xmm6
movdqa 160(%rsp), %xmm7

addq $184, %rsp

addq $56, %rsp

movq 8(%rbp),%r10 // Grab the return pointer.
incq %r10 // Skip past the `ret` in our parent frame
Expand Down