Skip to content

ThinLTO: Don't keep files open after mmaping them. #53962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2018
Merged

ThinLTO: Don't keep files open after mmaping them. #53962

merged 1 commit into from
Sep 5, 2018

Conversation

michaelwoerister
Copy link
Member

Fixes #53947.

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2018
@michaelwoerister
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Sep 5, 2018

⌛ Trying commit fc47a92 with merge bc802efeac5a8ebf285527449742e5047d0e09d5...

@michaelwoerister
Copy link
Member Author

@rust-timer build bc802efeac5a8ebf285527449742e5047d0e09d5

@rust-timer
Copy link
Collaborator

Success: Queued bc802efeac5a8ebf285527449742e5047d0e09d5 with parent 3f13b27, comparison URL.

@bors
Copy link
Collaborator

bors commented Sep 5, 2018

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton
Copy link
Member

r=me if perf comes back with a successful run!

Or just r=me in general, looks good!

@michaelwoerister
Copy link
Member Author

Yeah, the test run didn't make too much sense since the parent commit is still broken. Unless the build logs can be viewed somewhere. Anyway, I'm even going to up the priority so we get valid perf data sooner.

@bors r=alexcrichton p=1

@bors
Copy link
Collaborator

bors commented Sep 5, 2018

📌 Commit fc47a92 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2018
@michaelwoerister michaelwoerister mentioned this pull request Sep 5, 2018
Closed
@bors
Copy link
Collaborator

bors commented Sep 5, 2018

⌛ Testing commit fc47a92 with merge 6e0f1cc...

bors added a commit that referenced this pull request Sep 5, 2018
@bors
Auto merge of #53962 - michaelwoerister:close-thinlto-file-descriptor…
6e0f1cc 
…s, r=alexcrichton

ThinLTO: Don't keep files open after mmaping them.

Fixes #53947.

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Sep 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6e0f1cc to master...

@bors bors merged commit fc47a92 into rust-lang:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelwoerister @bors @rust-timer @alexcrichton @rust-highfive