Rollup of 8 pull requests #53400
Merged
Rollup of 8 pull requests #53400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve diagnostics for tests with custom return values This is an attempt at getting the ball rolling to improve the diagnostics for test functions that return custom `impl Termination` values (see rust-lang#52436). An alternative could be to use `eprintln!`, but including this in the panic message felt nicely consistent with how failing test assertions would be reported. Let me know what you think!
…iplett use ? to simplify `TransitiveRelation.maybe_map` I think this looks much clearer than the original.
…illaumeGomez Extend documentation of `rustc_on_unimplemented`
fix error for unsized packed struct field It was really confusing to be told "only the last field of a struct may have a dynamically sized type" when only the last field *was* unsized.
Add doc examples for std::alloc::{alloc,alloc_zeroed}.
None
Ignore test that fails on stage1 The error code is not emitted on stage1, so ignore this test there.
…rewsxcv Fix links' color Fixes rust-lang#53375. Problem was coming from the minifier. r? @frewsxcv
Fix since of Iterator::flatten to be a proper semver r? @kennytm
|
@bors: r+ p=8 |
|
📌 Commit b9a51ce has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 15, 2018
Rollup of 8 pull requests Successful merges: - #52453 (improve diagnostics for tests with custom return values) - #53271 (use ? to simplify `TransitiveRelation.maybe_map`) - #53279 (Extend documentation of `rustc_on_unimplemented`) - #53342 (fix error for unsized packed struct field) - #53344 (Add doc examples for std::alloc::{alloc,alloc_zeroed}.) - #53368 (Ignore test that fails on stage1) - #53388 (Fix links' color) - #53396 (Fix since of Iterator::flatten to be a proper semver) Failed merges: r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TransitiveRelation.maybe_map#53271 (use ? to simplifyTransitiveRelation.maybe_map)rustc_on_unimplemented#53279 (Extend documentation ofrustc_on_unimplemented)Failed merges:
r? @ghost