NLL: Walk the MIR only once for the "unused mut" lint #51660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
Jun 20, 2018
NLL: Walk the MIR only once for the "unused mut" lint Turns the quadratic loop gathering local variable assignments into a single MIR walk, and brings down the number of `super_mir` calls generated from `do_mir_borrowck` to the expected levels seen in `nll::replace_regions_in_mir` and `nll::compute_regions`, i.e. on clap: 1883 `super_mir` calls instead of 8011. The limited perf numbers I could gather on my machines look to be what we expected: `clap-check` seems to be gaining back a lot of the 7% we previously saw in `visit_mir`. Fixes #51641. r? @nikomatsakis
nikomatsakis
requested changes
Jun 20, 2018
| } | ||
|
|
||
| match place_context { | ||
| PlaceContext::Store | PlaceContext::Call => { |
There was a problem hiding this comment.
I wonder if we should factor this out to share code with the find_assignments
There was a problem hiding this comment.
basically just make a fn that returns a bool
There was a problem hiding this comment.
maybe share code with this function?
rust/src/librustc_mir/util/liveness.rs
Line 229 in 637fd2e
kennytm
added
the
S-waiting-on-perf
|
☀️ Test successful - status-travis |
kennytm
added
S-waiting-on-author
kennytm
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 63a4e72 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 63a4e72 with merge 16063f00f7b8a253cb2f15c4e405a402a997cb43... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@kennytm the failures look like CI network issues right ? |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 22, 2018
NLL: Walk the MIR only once for the "unused mut" lint Turns the quadratic loop gathering local variable assignments into a single MIR walk, and brings down the number of `super_mir` calls generated from `do_mir_borrowck` to the expected levels seen in `nll::replace_regions_in_mir` and `nll::compute_regions`, i.e. on clap: 1883 `super_mir` calls instead of 8011. The limited perf numbers I could gather on my machines look to be what we expected: `clap-check` seems to be gaining back a lot of the 7% we previously saw in `visit_mir`. Fixes #51641. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns the quadratic loop gathering local variable assignments into a single MIR walk, and brings down the number of
super_mircalls generated fromdo_mir_borrowckto the expected levels seen innll::replace_regions_in_mirandnll::compute_regions, i.e. on clap: 1883super_mircalls instead of 8011.The limited perf numbers I could gather on my machines look to be what we expected:
clap-checkseems to be gaining back a lot of the 7% we previously saw invisit_mir.Fixes #51641.
r? @nikomatsakis