Prevent Windows filesystem races in bootstrap tests #51596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they are unlikely to fail and are almost never going to fail except with bootstrap changes (which would be tested locally anyway) it makes sense to run these tests close to last.
rust-highfive
added
the
S-waiting-on-review
| @@ -416,6 +415,8 @@ impl<'a> Builder<'a> { | |||
| test::Clippy, | |||
| test::RustdocJS, | |||
| test::RustdocTheme, | |||
| // Run bootstrap close to the end as it's unlikely to fail | |||
|
Thanks! |
|
📌 Commit b436dca has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 16, 2018
…henkov Prevent Windows filesystem races in bootstrap tests Fixes #51595. This also makes bootstrap tests run near last in `./x.py test` invocations since they are unlikely to fail. r? @petrochenkov
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51595.
This also makes bootstrap tests run near last in
./x.py testinvocationssince they are unlikely to fail.
r? @petrochenkov