Skip to content

Update mdbook #50147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update mdbook #50147

wants to merge 1 commit into from

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Apr 21, 2018

cc @steveklabnik

This is safe to land because the only changes are CSS fixes and dependency updates.

This is important to land because some of those CSS bugs are really annoying. 😉

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2018

📌 Commit be1f242 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2018
@bors
Copy link
Collaborator

bors commented Apr 22, 2018

⌛ Testing commit be1f242 with merge d5efadd...

bors added a commit that referenced this pull request Apr 22, 2018
Update mdbook

cc @steveklabnik

This is safe to land because the only changes are CSS fixes and dependency updates.

This is important to land because some of those CSS bugs are really annoying. 😉
@bors
Copy link
Collaborator

bors commented Apr 22, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:02:32]  Downloading jobserver v0.1.11
[00:02:32]  Downloading mdbook v0.1.6
[00:02:32]  Downloading redox_syscall v0.1.37
[00:02:32]  Downloading xz2 v0.1.4
[00:02:32]  Downloading rust-stemmers v1.0.2
[00:02:32]  Downloading strum v0.9.0
[00:02:32]  Downloading userenv-sys v0.2.0
[00:02:32]  Downloading cargo_metadata v0.5.4
[00:02:32]  Downloading rustc-ap-serialize v103.0.0
---
[00:16:18] * wrapping_int_impl                lib      unstable     None    
[00:16:18] * wrapping_iter_arith              lib      stable       1.14.0  
[00:16:18] * wrapping_neg                     lib      stable       1.10.0  
[00:16:18] * wrapping_ref                     lib      stable       1.14.0  
[00:16:19] invalid license MIT/BSD-3-Clause in /checkout/obj/build/tmp/distcheck/src/vendor/rust-stemmers/Cargo.toml
[00:16:19] some tidy checks failed
[00:16:19] 
[00:16:19] 
[00:16:19] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:16:19] 
[00:16:19] 
[00:16:19] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:16:19] Build completed unsuccessfully in 0:03:13
[00:16:19] Build completed unsuccessfully in 0:03:13
[00:16:19] make: *** [check] Error 1
[00:16:19] Makefile:58: recipe for target 'check' failed
[00:16:19] 
[00:16:19] 
[00:16:19] command did not execute successfully: "make" "check"
[00:16:19] 
[00:16:19] 
[00:16:19] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:16:19] Build completed unsuccessfully in 0:13:37

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:02:32]  Downloading jobserver v0.1.11
[00:02:32]  Downloading mdbook v0.1.6
[00:02:32]  Downloading redox_syscall v0.1.37
[00:02:32]  Downloading xz2 v0.1.4
[00:02:32]  Downloading rust-stemmers v1.0.2
[00:02:32]  Downloading strum v0.9.0
[00:02:32]  Downloading userenv-sys v0.2.0
[00:02:32]  Downloading cargo_metadata v0.5.4
[00:02:32]  Downloading rustc-ap-serialize v103.0.0
---
[00:16:18] * wrapping_int_impl                lib      unstable     None    
[00:16:18] * wrapping_iter_arith              lib      stable       1.14.0  
[00:16:18] * wrapping_neg                     lib      stable       1.10.0  
[00:16:18] * wrapping_ref                     lib      stable       1.14.0  
[00:16:19] invalid license MIT/BSD-3-Clause in /checkout/obj/build/tmp/distcheck/src/vendor/rust-stemmers/Cargo.toml
[00:16:19] some tidy checks failed
[00:16:19] 
[00:16:19] 
[00:16:19] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:16:19] 
[00:16:19] 
[00:16:19] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:16:19] Build completed unsuccessfully in 0:03:13
[00:16:19] Build completed unsuccessfully in 0:03:13
[00:16:19] make: *** [check] Error 1
[00:16:19] Makefile:58: recipe for target 'check' failed
[00:16:19] 
[00:16:19] 
[00:16:19] command did not execute successfully: "make" "check"
[00:16:19] 
[00:16:19] 
[00:16:19] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:16:19] Build completed unsuccessfully in 0:13:37

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@mattico
Copy link
Contributor Author

mattico commented Apr 22, 2018

Ah interesting. I don't think that a MIT/BSD-3-Clause license is actually a problem, but that dependency isn't necessary for our english-only use of MDBook. I was already doing the work to make it optional, so I'll get to it. Probably need another version of MDBook published.

@mattico mattico closed this Apr 22, 2018
@mattico mattico deleted the update-mdbook branch April 22, 2018 18:04
@Michael-F-Bryan
Copy link

@mattico there's a new patch release of mdbook, should this be re-opened?

@mattico mattico mentioned this pull request Apr 23, 2018
bors added a commit that referenced this pull request Apr 23, 2018
Update MDBook

Updates MDBook to get some CSS fixes.

#50147, updated to resolve licensing issue.

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants