Put used trait imports field into a distinct query #45350
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
kennytm
added
the
S-waiting-on-review
src/librustc/ty/context.rs
Outdated
| /// This is used for warning unused imports. | ||
| pub used_trait_imports: DefIdSet, | ||
| /// This is used for warning unused imports. During type | ||
| /// checking, this field should not be cloned. |
There was a problem hiding this comment.
It'd be nice to say a bit more here -- maybe:
"During type checker, this Rc should not be cloned: it must always have a ref-count of 1 so that we can insert things into the set mutably."
src/librustc_typeck/check/mod.rs
Outdated
| fn used_trait_imports<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, | ||
| def_id: DefId) | ||
| -> Rc<DefIdSet> { | ||
| Rc::clone(&tcx.typeck_tables_of(def_id).used_trait_imports) |
There was a problem hiding this comment.
maybe just tcx.typeck_tables_of(def_id).used_trait_imports.clone()?
cjkenn
force-pushed
the
cjkenn/used-trait-imports
branch
from
b39e3bc to
6f30ce0
Compare
|
@bors r+ |
|
📌 Commit 6f30ce0 has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 6f30ce0 with merge 70504510d5b3ef7599e71806638d397b218aa726... |
|
The |
|
💔 Test failed - status-travis |
|
@bors retry |
Put used trait imports field into a distinct query Implementation for #45214 r+ @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Implementation for #45214
r+ @nikomatsakis