Skip to content

Add builder for Solaris and merge it with Fuchsia's builder #45001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 8, 2017
Merged

Add builder for Solaris and merge it with Fuchsia's builder #45001

merged 7 commits into from
Oct 8, 2017

Conversation

bgermann
Copy link
Contributor

@bgermann bgermann commented Oct 3, 2017

The new Solaris builder can be used to build rust-std.

The dilos illumos distribution was chosen, because illumos is free software
as opposed to Oracle Solaris and dilos is the only illumos distribution that
supports x86_64 and sparcv9 at the same level.

This can be used to build rust-std.

The dilos illumos distribution was chosen, because illumos is free software
as opposed to Oracle Solaris and dilos is the only illumos distribution that
supports x86_64 and sparcv9 at the same level.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bgermann
Copy link
Contributor Author

bgermann commented Oct 3, 2017

@alexcrichton Is there anything left that I can do to enable official rust-std builds for sparcv9-sun-solaris and x86_64-sun-solaris (and them being available in rustup)?

@alexcrichton
Copy link
Member

Thanks for the PR @bgermann! In terms of getting these available through rustup that'd basically require adding some form of a dist builder on Travis. Unfortunately adding entire new builders typically requires a big investment (we haven't done this in awhile) but if you can squeeze onto an existing builder then it normally works well.

It looks like you're just looking for the standard libraries here which are "easy" to build in the sense that they don't consume many resources. It looks like our cross builder is getting a little full at 1h44m as the last cycle time, but we could consider folding the dist-fuchsia builder into this builder as well (maybe even with the android builder if we're enterprising?)

@bgermann
Copy link
Contributor Author

bgermann commented Oct 4, 2017

You are right, I'm only looking for the standard libraries. To merge with dist-fuchsia sounds reasonable. Which name should the merged Docker environment have?

@alexcrichton
Copy link
Member

How about cross2

@bgermann bgermann changed the title Add build environment for Solaris Add builder for Solaris and merge it with Fuchsia's builder Oct 4, 2017
@alexcrichton
Copy link
Member

@bgermann Looks great! Could you also test out deleting the if: branch = auto temporarily? That'll allow us to see how long timing-wise this should take and ensure the builder passes before it reaches bors

@alexcrichton
Copy link
Member

@bors: r+

Awesome, thanks @bgermann!

@bors
Copy link
Collaborator

bors commented Oct 5, 2017

📌 Commit dba52ff has been approved by alexcrichton

@malbarbo
Copy link
Contributor

malbarbo commented Oct 5, 2017

@bgermann Great work, thanks! Do you know cross project? Maybe you can add support for cross compiling to sparc. It would be awesome.

@bgermann
Copy link
Contributor Author

bgermann commented Oct 5, 2017

I will have a look at it.

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 6, 2017
@bors
Copy link
Collaborator

bors commented Oct 8, 2017

⌛ Testing commit dba52ff with merge 108706f...

bors added a commit that referenced this pull request Oct 8, 2017
Add builder for Solaris and merge it with Fuchsia's builder

The new Solaris builder can be used to build rust-std.

The dilos illumos distribution was chosen, because illumos is free software
as opposed to Oracle Solaris and dilos is the only illumos distribution that
supports x86_64 and sparcv9 at the same level.
@bors
Copy link
Collaborator

bors commented Oct 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 108706f to master...

@bors bors merged commit dba52ff into rust-lang:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants