-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add builder for Solaris and merge it with Fuchsia's builder #45001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This can be used to build rust-std. The dilos illumos distribution was chosen, because illumos is free software as opposed to Oracle Solaris and dilos is the only illumos distribution that supports x86_64 and sparcv9 at the same level.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@alexcrichton Is there anything left that I can do to enable official rust-std builds for sparcv9-sun-solaris and x86_64-sun-solaris (and them being available in rustup)? |
Thanks for the PR @bgermann! In terms of getting these available through rustup that'd basically require adding some form of a dist builder on Travis. Unfortunately adding entire new builders typically requires a big investment (we haven't done this in awhile) but if you can squeeze onto an existing builder then it normally works well. It looks like you're just looking for the standard libraries here which are "easy" to build in the sense that they don't consume many resources. It looks like our |
You are right, I'm only looking for the standard libraries. To merge with dist-fuchsia sounds reasonable. Which name should the merged Docker environment have? |
How about |
@bgermann Looks great! Could you also test out deleting the |
📌 Commit dba52ff has been approved by |
I will have a look at it. |
Add builder for Solaris and merge it with Fuchsia's builder The new Solaris builder can be used to build rust-std. The dilos illumos distribution was chosen, because illumos is free software as opposed to Oracle Solaris and dilos is the only illumos distribution that supports x86_64 and sparcv9 at the same level.
☀️ Test successful - status-appveyor, status-travis |
The new Solaris builder can be used to build rust-std.
The dilos illumos distribution was chosen, because illumos is free software
as opposed to Oracle Solaris and dilos is the only illumos distribution that
supports x86_64 and sparcv9 at the same level.