-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Mir pretty print: Add cleanup comment #44919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I found it useful to add a comment indicating whether or not a BasicBlock is a cleanup block or not. Hopefully you'll find it useful too.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Example:
|
@bors r+ |
📌 Commit 6f8b69f has been approved by |
@bors rollup |
Mir pretty print: Add cleanup comment I found it useful to add a comment indicating whether or not a BasicBlock is a cleanup block or not. Hopefully you'll find it useful too.
☀️ Test successful - status-appveyor, status-travis |
I found it useful to add a comment indicating whether or not a
BasicBlock is a cleanup block or not. Hopefully you'll find it
useful too.